Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7315)

Unified Diff: chrome/browser/resources/options/search_engine_manager_engine_list.js

Issue 684493002: Don't persist and sync omnibox extension keywords. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/search_engines/keyword_editor_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/search_engine_manager_engine_list.js
diff --git a/chrome/browser/resources/options/search_engine_manager_engine_list.js b/chrome/browser/resources/options/search_engine_manager_engine_list.js
index 2076f26b920899268f59b3763e01085081ea7994..f94a01bb16085df17e6c3d21714cba63af46a230 100644
--- a/chrome/browser/resources/options/search_engine_manager_engine_list.js
+++ b/chrome/browser/resources/options/search_engine_manager_engine_list.js
@@ -10,7 +10,7 @@
* displayName: string,
* extension: (Object|undefined),
* iconURL: (string|undefined),
- * isExtension: boolean,
+ * isOmniboxExtension: boolean,
* keyword: string,
* modelIndex: string,
* name: string,
@@ -141,7 +141,7 @@ cr.define('options.search_engines', function() {
// And the URL column.
var urlEl = this.createEditableTextCell(engine.url);
// Extensions should not display a URL column.
- if (!engine.isExtension) {
+ if (!engine.isOmniboxExtension) {
var urlWithButtonEl = this.ownerDocument.createElement('div');
urlWithButtonEl.appendChild(urlEl);
urlWithButtonEl.className = 'url-column';
@@ -181,9 +181,6 @@ cr.define('options.search_engines', function() {
if (engine.urlLocked)
this.urlField_.disabled = true;
- if (engine.isExtension)
- this.nameField_.disabled = true;
-
if (this.isPlaceholder) {
this.nameField_.placeholder =
loadTimeData.getString('searchEngineTableNamePlaceholder');
« no previous file with comments | « no previous file | chrome/browser/ui/search_engines/keyword_editor_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698