Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: chrome/browser/ui/search_engines/keyword_editor_controller.cc

Issue 684493002: Don't persist and sync omnibox extension keywords. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/search_engines/keyword_editor_controller.h" 5 #include "chrome/browser/ui/search_engines/keyword_editor_controller.h"
6 6
7 #include "base/prefs/pref_registry_simple.h" 7 #include "base/prefs/pref_registry_simple.h"
8 #include "chrome/browser/favicon/favicon_service_factory.h" 8 #include "chrome/browser/favicon/favicon_service_factory.h"
9 #include "chrome/browser/search_engines/template_url_service_factory.h" 9 #include "chrome/browser/search_engines/template_url_service_factory.h"
10 #include "chrome/browser/ui/search_engines/template_url_table_model.h" 10 #include "chrome/browser/ui/search_engines/template_url_table_model.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 if ((template_url->short_name() == title) && 53 if ((template_url->short_name() == title) &&
54 (template_url->keyword() == keyword) && (template_url->url() == url)) 54 (template_url->keyword() == keyword) && (template_url->url() == url))
55 return; 55 return;
56 56
57 table_model_->ModifyTemplateURL(index, title, keyword, url); 57 table_model_->ModifyTemplateURL(index, title, keyword, url);
58 58
59 content::RecordAction(UserMetricsAction("KeywordEditor_ModifiedKeyword")); 59 content::RecordAction(UserMetricsAction("KeywordEditor_ModifiedKeyword"));
60 } 60 }
61 61
62 bool KeywordEditorController::CanEdit(const TemplateURL* url) const { 62 bool KeywordEditorController::CanEdit(const TemplateURL* url) const {
63 return (url->GetType() != TemplateURL::NORMAL_CONTROLLED_BY_EXTENSION) && 63 return (url->GetType() == TemplateURL::NORMAL) &&
64 (!url_model_->is_default_search_managed() || 64 (url != url_model_->GetDefaultSearchProvider() ||
65 (url != url_model_->GetDefaultSearchProvider())); 65 !url_model_->is_default_search_managed());
66 } 66 }
67 67
68 bool KeywordEditorController::CanMakeDefault(const TemplateURL* url) const { 68 bool KeywordEditorController::CanMakeDefault(const TemplateURL* url) const {
69 return url_model_->CanMakeDefault(url); 69 return url_model_->CanMakeDefault(url);
70 } 70 }
71 71
72 bool KeywordEditorController::CanRemove(const TemplateURL* url) const { 72 bool KeywordEditorController::CanRemove(const TemplateURL* url) const {
73 return url != url_model_->GetDefaultSearchProvider(); 73 return (url->GetType() == TemplateURL::NORMAL) &&
74 (url != url_model_->GetDefaultSearchProvider());
74 } 75 }
75 76
76 void KeywordEditorController::RemoveTemplateURL(int index) { 77 void KeywordEditorController::RemoveTemplateURL(int index) {
77 table_model_->Remove(index); 78 table_model_->Remove(index);
78 content::RecordAction(UserMetricsAction("KeywordEditor_RemoveKeyword")); 79 content::RecordAction(UserMetricsAction("KeywordEditor_RemoveKeyword"));
79 } 80 }
80 81
81 TemplateURL* KeywordEditorController::GetDefaultSearchProvider() { 82 TemplateURL* KeywordEditorController::GetDefaultSearchProvider() {
82 return url_model_->GetDefaultSearchProvider(); 83 return url_model_->GetDefaultSearchProvider();
83 } 84 }
84 85
85 int KeywordEditorController::MakeDefaultTemplateURL(int index) { 86 int KeywordEditorController::MakeDefaultTemplateURL(int index) {
86 return table_model_->MakeDefaultTemplateURL(index); 87 return table_model_->MakeDefaultTemplateURL(index);
87 } 88 }
88 89
89 bool KeywordEditorController::loaded() const { 90 bool KeywordEditorController::loaded() const {
90 return url_model_->loaded(); 91 return url_model_->loaded();
91 } 92 }
92 93
93 TemplateURL* KeywordEditorController::GetTemplateURL(int index) { 94 TemplateURL* KeywordEditorController::GetTemplateURL(int index) {
94 return table_model_->GetTemplateURL(index); 95 return table_model_->GetTemplateURL(index);
95 } 96 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698