Revert unintended prevention of seeks on infinite duration media.

Revert unintended prevention of seeks on infinite duration media.

Preserves the looping behavior for 200-type sources, while reverting
the disabling of seeks for "non-streaming" type sources which report
an infinite duration. This reverts the unintended behavior change
from http://crrev.com/298565

BUG=412562, 427412
TEST=live player works again. LayoutTest forthcoming.

Committed: https://crrev.com/56359cbf0a9a17b4dd615fd71ac1b3060fe8a18e
Cr-Commit-Position: refs/heads/master@{#301495}

[DaleCurtis, 2014-10-27 18:50:37]

dalecurtis@chromium.org changed reviewers:
+ wolenetz@chromium.org

[wolenetz, 2014-10-27 20:14:26]

looking good % a nit and clarification request:

https://codereview.chromium.org/684473002/diff/1/content/renderer/media/andro...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/684473002/diff/1/content/renderer/media/andro...
content/renderer/media/android/webmediaplayer_android.cc:14: #include
"base/float_util.h"
nit: do we no longer need this since we're dropping base::IsFinite usage in this
CL?

https://codereview.chromium.org/684473002/diff/1/content/renderer/media/andro...
content/renderer/media/android/webmediaplayer_android.cc:534: const
blink::WebTimeRange seekable_range(0.0, duration());
Versus pre-621573002, we now allow for duration() to be 0.0, and return seekable
range [0.0,0.0] instead of empty WebTimeRanges().  Is this intended?

[wolenetz, 2014-10-27 20:15:21]

Also, does this break layout tests?

[DaleCurtis, 2014-10-27 20:20:41]

It does not break layout tests, all the new tests work as expected, since they
only test the intended change.

https://codereview.chromium.org/684473002/diff/1/content/renderer/media/andro...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/684473002/diff/1/content/renderer/media/andro...
content/renderer/media/android/webmediaplayer_android.cc:14: #include
"base/float_util.h"
On 2014/10/27 20:14:25, wolenetz wrote:
> nit: do we no longer need this since we're dropping base::IsFinite usage in
this
> CL?

Done.

https://codereview.chromium.org/684473002/diff/1/content/renderer/media/andro...
content/renderer/media/android/webmediaplayer_android.cc:534: const
blink::WebTimeRange seekable_range(0.0, duration());
On 2014/10/27 20:14:25, wolenetz wrote:
> Versus pre-621573002, we now allow for duration() to be 0.0, and return
seekable
> range [0.0,0.0] instead of empty WebTimeRanges().  Is this intended?

Nice eye, it was intended in my original CL and I didn't see any reason to
revert that behavior here. It ensures the media always has a seekable range. 
Support for 200-type sources is at the mercy of Android's player.

[wolenetz, 2014-10-27 20:26:47]

lgtm

https://codereview.chromium.org/684473002/diff/1/content/renderer/media/andro...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/684473002/diff/1/content/renderer/media/andro...
content/renderer/media/android/webmediaplayer_android.cc:534: const
blink::WebTimeRange seekable_range(0.0, duration());
On 2014/10/27 20:20:41, DaleCurtis wrote:
> On 2014/10/27 20:14:25, wolenetz wrote:
> > Versus pre-621573002, we now allow for duration() to be 0.0, and return
> seekable
> > range [0.0,0.0] instead of empty WebTimeRanges().  Is this intended?
> 
> Nice eye, it was intended in my original CL and I didn't see any reason to
> revert that behavior here. It ensures the media always has a seekable range. 
> Support for 200-type sources is at the mercy of Android's player.

Acknowledged.

[DaleCurtis, 2014-10-27 20:27:07]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2014-10-27 20:30:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/684473002/20001

[commit-bot: I haz the power, 2014-10-28 00:07:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-28 00:07:57]

Patchset 2 (id:??) landed as
https://crrev.com/56359cbf0a9a17b4dd615fd71ac1b3060fe8a18e
Cr-Commit-Position: refs/heads/master@{#301495}