Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 684463004: Remove !typeFace early return in fontFamilyName (Closed)

Created:
6 years, 1 month ago by rwlbuis
Modified:
6 years, 1 month ago
Reviewers:
eae
CC:
blink-reviews, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove !typeFace early return in fontFamilyName This early return was protecting against SVG Font usage, however SVG Fonts were removed in https://codereview.chromium.org/656913006, so convert into an ASSERT instead and remove the outdated comment. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M Source/platform/fonts/FontPlatformData.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
6 years, 1 month ago (2014-10-28 01:43:43 UTC) #2
eae
Makes sense, LGTM
6 years, 1 month ago (2014-11-03 19:52:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684463004/1
6 years, 1 month ago (2014-11-03 21:14:52 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 22:01:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184804

Powered by Google App Engine
This is Rietveld 408576698