Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 684453004: Make ChromeShell activity use AppCompat theme to match official Chrome. (Closed)

Created:
6 years, 1 month ago by aurimas (slooooooooow)
Modified:
6 years, 1 month ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make ChromeShell activity use AppCompat theme to match official Chrome. BUG=None Committed: https://crrev.com/7cba80787b84cbde3255684da10a2299c7af36e0 Cr-Commit-Position: refs/heads/master@{#301531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M chrome/android/shell/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/shell/res/drawable/progress.xml View 1 chunk +1 line, -1 line 0 comments Download
A chrome/android/shell/res/values-v17/styles.xml View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aurimas (slooooooooow)
nyquist: PTAL
6 years, 1 month ago (2014-10-27 21:16:10 UTC) #2
nyquist
nice! lgtm
6 years, 1 month ago (2014-10-27 22:55:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684453004/1
6 years, 1 month ago (2014-10-27 23:20:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 01:08:31 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 01:09:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cba80787b84cbde3255684da10a2299c7af36e0
Cr-Commit-Position: refs/heads/master@{#301531}

Powered by Google App Engine
This is Rietveld 408576698