Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: third_party/android_crazy_linker/src/src/crazy_linker_zip.h

Issue 684453003: Add UMA for testing whether the Chromium library was page aligned in the APK file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added asserts to crazy linker Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/android_crazy_linker/src/src/crazy_linker_zip.h
diff --git a/third_party/android_crazy_linker/src/src/crazy_linker_zip.h b/third_party/android_crazy_linker/src/src/crazy_linker_zip.h
index 6e289c064892e199b1ef2844c2aa9871c4d089c5..75adcf8aac8df76445b68135a642f9898b299e5e 100644
--- a/third_party/android_crazy_linker/src/src/crazy_linker_zip.h
+++ b/third_party/android_crazy_linker/src/src/crazy_linker_zip.h
@@ -7,12 +7,16 @@
// Definitions related to supporting loading libraries from zip files.
+// Offset in a file indicating a failure.
+#define CRAZY_OFFSET_FAILED (-1)
+
namespace crazy {
// Find "filename" in the specified "zip_file" and return the offset
-// in the file of the start of the data for the file. Return -1 on error.
-// This routine replaces code which used the minizip library, but is about
-// 150 times faster, locating the offset in less than 0.5ms on a Nexus 4.
+// in the file of the start of the data for the file. Return
+// CRAZY_OFFSET_FAILED on error. This routine replaces code which used the
+// minizip library, but is about 150 times faster, locating the offset in less
+// than 0.5ms on a Nexus 4.
int FindStartOffsetOfFileInZipFile(const char* zip_file, const char* filename);
}

Powered by Google App Engine
This is Rietveld 408576698