Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: third_party/android_crazy_linker/src/src/crazy_linker_api.cpp

Issue 684453003: Add UMA for testing whether the Chromium library was page aligned in the APK file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added asserts to crazy linker Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/android_crazy_linker/src/src/crazy_linker_api.cpp
diff --git a/third_party/android_crazy_linker/src/src/crazy_linker_api.cpp b/third_party/android_crazy_linker/src/src/crazy_linker_api.cpp
index 10a64bfa63ee9b6290ba88a64ec33340d48073e4..8c56dfa5d38ec458a6d64a17330e8190d0350030 100644
--- a/third_party/android_crazy_linker/src/src/crazy_linker_api.cpp
+++ b/third_party/android_crazy_linker/src/src/crazy_linker_api.cpp
@@ -372,6 +372,16 @@ crazy_status_t crazy_library_find_from_address(void* address,
}
}
+crazy_status_t crazy_linker_check_library_aligned_in_zip_file(
+ const char* zipfile_name,
+ const char* lib_name) {
+ if (crazy::LibraryList::FindAlignedLibraryInZipFile(
+ zipfile_name, lib_name, NULL) == -1)
+ return CRAZY_STATUS_FAILURE;
picksi1 2014/10/28 12:38:33 Can you use CRAZY_OFFSET_FAILED here too? Or is it
petrcermak 2014/10/28 13:48:16 Done (needed to move CRAZY_OFFSET_FAILED to crazy_
+
+ return CRAZY_STATUS_SUCCESS;
+}
+
void crazy_library_close(crazy_library_t* library) {
crazy_library_close_with_context(library, NULL);
}

Powered by Google App Engine
This is Rietveld 408576698