third_party/android_crazy_linker/src/src/crazy_linker_zip.h - Issue 684453003: Add UMA for testing whether the Chromium library was page aligned in the APK file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/android_crazy_linker/src/src/crazy_linker_zip.h

Issue 684453003: Add UMA for testing whether the Chromium library was page aligned in the APK file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update for review feedback Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/android_crazy_linker/src/src/crazy_linker_util.h ('k') | third_party/android_crazy_linker/src/src/crazy_linker_zip.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/android_crazy_linker/src/src/crazy_linker_zip.h

diff --git a/third_party/android_crazy_linker/src/src/crazy_linker_zip.h b/third_party/android_crazy_linker/src/src/crazy_linker_zip.h

index 6e289c064892e199b1ef2844c2aa9871c4d089c5..38654938e7b88c6ea4813d3e87d4f4ffca3927a4 100644

--- a/third_party/android_crazy_linker/src/src/crazy_linker_zip.h

+++ b/third_party/android_crazy_linker/src/src/crazy_linker_zip.h

@@ -10,9 +10,10 @@

namespace crazy {

// Find "filename" in the specified "zip_file" and return the offset

-// in the file of the start of the data for the file. Return -1 on error.

-// This routine replaces code which used the minizip library, but is about

-// 150 times faster, locating the offset in less than 0.5ms on a Nexus 4.

+// in the file of the start of the data for the file. Return

+// CRAZY_OFFSET_FAILED on error. This routine replaces code which used the

+// minizip library, but is about 150 times faster, locating the offset in less

+// than 0.5ms on a Nexus 4.

int FindStartOffsetOfFileInZipFile(const char* zip_file, const char* filename);

}