Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: third_party/android_crazy_linker/src/src/crazy_linker_library_list.h

Issue 684453003: Add UMA for testing whether the Chromium library was page aligned in the APK file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/android_crazy_linker/src/src/crazy_linker_library_list.h
diff --git a/third_party/android_crazy_linker/src/src/crazy_linker_library_list.h b/third_party/android_crazy_linker/src/src/crazy_linker_library_list.h
index 9759a77a6e50b9b9bfd3dfa8e2e91bcc339e9235..6de445fba8f04cb1d08c9f62a264a0fae40e61a8 100644
--- a/third_party/android_crazy_linker/src/src/crazy_linker_library_list.h
+++ b/third_party/android_crazy_linker/src/src/crazy_linker_library_list.h
@@ -80,6 +80,14 @@ class LibraryList {
SearchPathList* search_path_list,
Error* error);
+ // Find the location of a library in the zip file. If the name of the library
+ // is too long, an error occurs during the search or the library is not
+ // page aligned in the zip file, -1 is returned. Otherwise, the offset of
+ // the library in the zip file is returned.
+ static int FindAlignedLibraryInZipFile(const char* zip_file_path,
+ const char* lib_name,
+ Error* error);
+
// Unload a given shared library. This really decrements the library's
// internal reference count. When it reaches zero, the library's
// destructors are run, its dependencies are unloaded, then the

Powered by Google App Engine
This is Rietveld 408576698