Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Side by Side Diff: base/android/library_loader/library_loader_hooks.cc

Issue 684453003: Add UMA for testing whether the Chromium library was page aligned in the APK file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/library_loader/library_loader_hooks.h" 5 #include "base/android/library_loader/library_loader_hooks.h"
6 6
7 #include "base/android/command_line_android.h" 7 #include "base/android/command_line_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "base/android/library_loader/library_load_from_apk_status_codes.h" 9 #include "base/android/library_loader/library_load_from_apk_status_codes.h"
10 #include "base/at_exit.h" 10 #include "base/at_exit.h"
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 UMA_HISTOGRAM_ENUMERATION("ChromiumAndroidLinker.BrowserStates", 91 UMA_HISTOGRAM_ENUMERATION("ChromiumAndroidLinker.BrowserStates",
92 histogram_code, 92 histogram_code,
93 MAX_BROWSER_HISTOGRAM_CODE); 93 MAX_BROWSER_HISTOGRAM_CODE);
94 94
95 // Record the device support for loading a library directly from the APK file. 95 // Record the device support for loading a library directly from the APK file.
96 UMA_HISTOGRAM_ENUMERATION("ChromiumAndroidLinker.LibraryLoadFromApkStatus", 96 UMA_HISTOGRAM_ENUMERATION("ChromiumAndroidLinker.LibraryLoadFromApkStatus",
97 library_load_from_apk_status, 97 library_load_from_apk_status,
98 LIBRARY_LOAD_FROM_APK_STATUS_CODES_MAX); 98 LIBRARY_LOAD_FROM_APK_STATUS_CODES_MAX);
99 } 99 }
100 100
101 static void RecordChromiumAndroidLinkerLibraryAlignmentInApk(
102 JNIEnv* env,
103 jclass clazz,
104 jboolean aligned) {
105 // Record whether the Chromium library is page aligned in the APK file.
106 UMA_HISTOGRAM_BOOLEAN("ChromiumAndroidLinker.LibraryAlignedInApk", aligned);
107 }
108
101 void SetLibraryLoadedHook(LibraryLoadedHook* func) { 109 void SetLibraryLoadedHook(LibraryLoadedHook* func) {
102 g_registration_callback = func; 110 g_registration_callback = func;
103 } 111 }
104 112
105 static void InitCommandLine(JNIEnv* env, jclass clazz, 113 static void InitCommandLine(JNIEnv* env, jclass clazz,
106 jobjectArray init_command_line) { 114 jobjectArray init_command_line) {
107 InitNativeCommandLineFromJavaArray(env, init_command_line); 115 InitNativeCommandLineFromJavaArray(env, init_command_line);
108 } 116 }
109 117
110 static jboolean LibraryLoaded(JNIEnv* env, jclass clazz) { 118 static jboolean LibraryLoaded(JNIEnv* env, jclass clazz) {
(...skipping 24 matching lines...) Expand all
135 jstring GetVersionNumber(JNIEnv* env, jclass clazz) { 143 jstring GetVersionNumber(JNIEnv* env, jclass clazz) {
136 return ConvertUTF8ToJavaString(env, g_library_version_number).Release(); 144 return ConvertUTF8ToJavaString(env, g_library_version_number).Release();
137 } 145 }
138 146
139 static void RecordNativeLibraryHack(JNIEnv*, jclass, jboolean usedHack) { 147 static void RecordNativeLibraryHack(JNIEnv*, jclass, jboolean usedHack) {
140 UMA_HISTOGRAM_BOOLEAN("LibraryLoader.NativeLibraryHack", usedHack); 148 UMA_HISTOGRAM_BOOLEAN("LibraryLoader.NativeLibraryHack", usedHack);
141 } 149 }
142 150
143 } // namespace android 151 } // namespace android
144 } // namespace base 152 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698