Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 684423005: Add logs to debug a flakiness on GPU Mac bots. (Closed)

Created:
6 years, 1 month ago by Zhenyao Mo
Modified:
6 years, 1 month ago
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, piman+watch_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add logs to debug a flakiness on GPU Mac bots. This is temporary and will be removed after we pin down the issue. BUG=424024 TEST= R=kbr@chromium.org TBR=dgozman@chromium.org NOTRY=true Committed: https://crrev.com/16aa242c3456dc68cd91ef2c683158799c8441b0 Cr-Commit-Position: refs/heads/master@{#302371}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M content/browser/devtools/devtools_http_handler_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/devtools/devtools_system_info_handler.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 4 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Zhenyao Mo
PTAL
6 years, 1 month ago (2014-10-31 23:29:58 UTC) #1
Ken Russell (switch to Gerrit)
+more content/browser/devtools OWNERS LGTM so long as it's been determined that these VLOGs can actually ...
6 years, 1 month ago (2014-10-31 23:39:44 UTC) #3
Zhenyao Mo
Verified, in crash, we are able to see the added logs. Landing this with fixed ...
6 years, 1 month ago (2014-11-01 00:57:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684423005/20001
6 years, 1 month ago (2014-11-01 00:59:08 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-01 01:00:30 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/16aa242c3456dc68cd91ef2c683158799c8441b0 Cr-Commit-Position: refs/heads/master@{#302371}
6 years, 1 month ago (2014-11-01 01:01:50 UTC) #8
Zhenyao Mo
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/684253003/ by zmo@chromium.org. ...
6 years, 1 month ago (2014-11-01 16:21:46 UTC) #9
Zhenyao Mo
6 years, 1 month ago (2014-11-04 21:14:24 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/698353002/ by zmo@chromium.org.

The reason for reverting is: It was temporary and no longer needed..

Powered by Google App Engine
This is Rietveld 408576698