Issue 684413003: Revert "[turbofan] Fix select lowering."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 684413003: Revert "[turbofan] Fix select lowering." (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer

Modified:
6 years, 1 month ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Revert "[turbofan] Fix select lowering." This reverts commit cf08e8d70ff0fa35dd315ddc430b743bb04c89cf for breaking Embenchen bullet. TBR=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25238

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -61 lines)			Patch
M	src/compiler/node.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/compiler/select-lowering.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/compiler/select-lowering.cc	View	1 chunk	+11 lines, -43 lines	0 comments	Download
M	test/unittests/compiler/select-lowering-unittest.cc	View	3 chunks	+2 lines, -12 lines	0 comments	Download

Total messages: 2 (0 generated)

Benedikt Meurer

6 years, 1 month ago (2014-11-10 10:43:12 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 25238 (presubmit successful).