sky/engine/core/rendering/RenderObject.cpp - Issue 684393002: Remove flipForWritingMode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderObject.cpp

Issue 684393002: Remove flipForWritingMode. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderObject.cpp

diff --git a/sky/engine/core/rendering/RenderObject.cpp b/sky/engine/core/rendering/RenderObject.cpp

index 829a830740034ea39fc8694fa5a97af2881e2090..f7bdd2ade8a44befbcf695e967963fe1d21b0c7e 100644

--- a/sky/engine/core/rendering/RenderObject.cpp

+++ b/sky/engine/core/rendering/RenderObject.cpp

@@ -1415,6 +1415,7 @@ InvalidationReason RenderObject::invalidatePaintIfNeeded(const RenderLayerModelO

const LayoutRect& newBounds = previousPaintInvalidationRect();

const LayoutPoint& newLocation = previousPositionFromPaintInvalidationContainer();

+ // FIXME(sky): Do we need this now that we don't have flipForWritingMode?

// FIXME: PaintInvalidationState should not be required here, but the call to flipForWritingMode

// in mapRectToPaintInvalidationBacking will give us the wrong results with it disabled.

// crbug.com/393762