sky/engine/core/rendering/RenderLineBoxList.cpp - Issue 684393002: Remove flipForWritingMode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderLineBoxList.cpp

Issue 684393002: Remove flipForWritingMode. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderLineBoxList.cpp

diff --git a/sky/engine/core/rendering/RenderLineBoxList.cpp b/sky/engine/core/rendering/RenderLineBoxList.cpp

index e0cf849bb1ad33e35cd5168a661c386d754e1642..75bb637eafd3a7866f748533c71c1d59a57ebdaa 100644

--- a/sky/engine/core/rendering/RenderLineBoxList.cpp

+++ b/sky/engine/core/rendering/RenderLineBoxList.cpp

@@ -150,8 +150,8 @@ bool RenderLineBoxList::rangeIntersectsRect(RenderBoxModelObject* renderer, Layo

block = toRenderBox(renderer);

else

block = renderer->containingBlock();

- LayoutUnit physicalStart = block->flipForWritingMode(logicalTop);

- LayoutUnit physicalEnd = block->flipForWritingMode(logicalBottom);

+ LayoutUnit physicalStart = logicalTop;

+ LayoutUnit physicalEnd = logicalBottom;

LayoutUnit physicalExtent = absoluteValue(physicalEnd - physicalStart);

physicalStart = std::min(physicalStart, physicalEnd);