Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 684383004: If no device specified, get the first device found (Closed)

Created:
6 years, 1 month ago by danduong
Modified:
6 years, 1 month ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

If no device specified, get the first device found This makes adb_reverse_forwarder.py a little more convenient to use. BUG=429859 Committed: https://crrev.com/a21bde9f055f3ed2cfc36f3022cabad0e44831b0 Cr-Commit-Position: refs/heads/master@{#302548}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M build/android/adb_reverse_forwarder.py View 1 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
danduong
6 years, 1 month ago (2014-11-03 23:13:22 UTC) #2
jbudorick
lgtm w/ nit Also, because I'm curious: where are you using this? https://codereview.chromium.org/684383004/diff/1/build/android/adb_reverse_forwarder.py File build/android/adb_reverse_forwarder.py ...
6 years, 1 month ago (2014-11-03 23:22:50 UTC) #3
danduong
https://codereview.chromium.org/684383004/diff/1/build/android/adb_reverse_forwarder.py File build/android/adb_reverse_forwarder.py (right): https://codereview.chromium.org/684383004/diff/1/build/android/adb_reverse_forwarder.py#newcode62 build/android/adb_reverse_forwarder.py:62: if not devices: On 2014/11/03 23:22:50, jbudorick wrote: > ...
6 years, 1 month ago (2014-11-04 00:21:48 UTC) #4
jbudorick
lgtm
6 years, 1 month ago (2014-11-04 00:23:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684383004/20001
6 years, 1 month ago (2014-11-04 00:24:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-04 02:14:46 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 02:15:31 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a21bde9f055f3ed2cfc36f3022cabad0e44831b0
Cr-Commit-Position: refs/heads/master@{#302548}

Powered by Google App Engine
This is Rietveld 408576698