Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: sky/engine/core/rendering/style/RenderStyle.h

Issue 684383002: Delete a ton more dead vertical writing mode code. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode1
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/style/RenderStyle.h
diff --git a/sky/engine/core/rendering/style/RenderStyle.h b/sky/engine/core/rendering/style/RenderStyle.h
index 7914b0994da7ceb6545cfaf209d5b1df20e59310..e844f15ad77688ec06b457824a5f5429426b7253 100644
--- a/sky/engine/core/rendering/style/RenderStyle.h
+++ b/sky/engine/core/rendering/style/RenderStyle.h
@@ -831,11 +831,6 @@ public:
const LineClampValue& lineClamp() const { return rareNonInheritedData->lineClamp; }
Color tapHighlightColor() const { return rareInheritedData->tapHighlightColor; }
- // FIXME(sky): Remove these.
- bool isHorizontalWritingMode() const { return true; }
- bool isFlippedLinesWritingMode() const { return false; }
- bool isFlippedBlocksWritingMode() const { return false; }
-
EImageRendering imageRendering() const { return static_cast<EImageRendering>(rareInheritedData->m_imageRendering); }
ESpeak speak() const { return static_cast<ESpeak>(rareInheritedData->speak); }
@@ -852,7 +847,7 @@ public:
void setIsolation(EIsolation v);
bool hasIsolation() const;
- bool shouldPlaceBlockDirectionScrollbarOnLogicalLeft() const { return !isLeftToRightDirection() && isHorizontalWritingMode(); }
+ bool shouldPlaceBlockDirectionScrollbarOnLogicalLeft() const { return !isLeftToRightDirection(); }
TouchAction touchAction() const { return static_cast<TouchAction>(rareNonInheritedData->m_touchAction); }
TouchActionDelay touchActionDelay() const { return static_cast<TouchActionDelay>(rareInheritedData->m_touchActionDelay); }
@@ -882,20 +877,14 @@ public:
void setLogicalWidth(const Length& v)
{
- if (isHorizontalWritingMode()) {
- SET_VAR(m_box, m_width, v);
- } else {
- SET_VAR(m_box, m_height, v);
- }
+ // FIXME(sky): Remove
+ SET_VAR(m_box, m_width, v);
}
void setLogicalHeight(const Length& v)
{
- if (isHorizontalWritingMode()) {
- SET_VAR(m_box, m_height, v);
- } else {
- SET_VAR(m_box, m_width, v);
- }
+ // FIXME(sky): Remove
+ SET_VAR(m_box, m_height, v);
}
void setMinWidth(const Length& v) { SET_VAR(m_box, m_minWidth, v); }
« no previous file with comments | « sky/engine/core/rendering/shapes/ShapeOutsideInfo.cpp ('k') | sky/engine/core/rendering/style/RenderStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698