Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: sky/engine/core/rendering/RenderLineBoxList.cpp

Issue 684383002: Delete a ton more dead vertical writing mode code. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode1
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderInline.cpp ('k') | sky/engine/core/rendering/RenderObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderLineBoxList.cpp
diff --git a/sky/engine/core/rendering/RenderLineBoxList.cpp b/sky/engine/core/rendering/RenderLineBoxList.cpp
index dd437ba900ed1ec442e0a0d735fdb94c58bb748a..e0cf849bb1ad33e35cd5168a661c386d754e1642 100644
--- a/sky/engine/core/rendering/RenderLineBoxList.cpp
+++ b/sky/engine/core/rendering/RenderLineBoxList.cpp
@@ -155,15 +155,9 @@ bool RenderLineBoxList::rangeIntersectsRect(RenderBoxModelObject* renderer, Layo
LayoutUnit physicalExtent = absoluteValue(physicalEnd - physicalStart);
physicalStart = std::min(physicalStart, physicalEnd);
- if (renderer->style()->isHorizontalWritingMode()) {
- physicalStart += offset.y();
- if (physicalStart >= rect.maxY() || physicalStart + physicalExtent <= rect.y())
- return false;
- } else {
- physicalStart += offset.x();
- if (physicalStart >= rect.maxX() || physicalStart + physicalExtent <= rect.x())
- return false;
- }
+ physicalStart += offset.y();
+ if (physicalStart >= rect.maxY() || physicalStart + physicalExtent <= rect.y())
+ return false;
return true;
}
« no previous file with comments | « sky/engine/core/rendering/RenderInline.cpp ('k') | sky/engine/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698