sky/engine/core/rendering/RenderGeometryMap.cpp - Issue 684383002: Delete a ton more dead vertical writing mode code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderGeometryMap.cpp

Issue 684383002: Delete a ton more dead vertical writing mode code. (Closed) Base URL: git@github.com:domokit/mojo.git@writingmode1

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderGeometryMap.cpp

diff --git a/sky/engine/core/rendering/RenderGeometryMap.cpp b/sky/engine/core/rendering/RenderGeometryMap.cpp

index 516c19de0632bbe78a4c959965400684f2e1d84c..b1c16611661019e66cd48941f526f87f6f2f5ca2 100644

--- a/sky/engine/core/rendering/RenderGeometryMap.cpp

+++ b/sky/engine/core/rendering/RenderGeometryMap.cpp

@@ -179,10 +179,6 @@ void RenderGeometryMap::pushMappingsToAncestor(const RenderObject* renderer, con

static bool canMapBetweenRenderers(const RenderObject* renderer, const RenderObject* ancestor)

{

for (const RenderObject* current = renderer; ; current = current->parent()) {

- const RenderStyle* style = current->style();

- if (style->isFlippedBlocksWritingMode())

- return false;

if (current->hasTransform())

return false;