Issue 684373004: Fix potential edge case crashes in ExtensionToolbarModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 684373004: Fix potential edge case crashes in ExtensionToolbarModel (Closed)

Created:
6 years, 1 month ago by Devlin

Modified:
6 years, 1 month ago

Reviewers:
Finnur

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@dc_toolbar_fix_incognito_stuff

Project:
chromium

Visibility:
Public.

Fix potential edge case crashes in ExtensionToolbarModel Fix two potential crashes in ExtensionToolbarModel. Committed: https://crrev.com/564ecc1797f63f0ac90d8d5fbb64a69c29c267d7 Cr-Commit-Position: refs/heads/master@{#302461}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	chrome/browser/extensions/extension_toolbar_model.cc	View		2 chunks	+10 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684373004/1

6 years, 1 month ago (2014-11-03 18:38:51 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-03 19:23:45 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/564ecc1797f63f0ac90d8d5fbb64a69c29c267d7
Cr-Commit-Position: refs/heads/master@{#302461}