Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 684373003: Fixing crashes in layout tests when virtual-viewport is enabled. (Closed)

Created:
6 years, 1 month ago by bokan
Modified:
6 years, 1 month ago
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fixing crashes in layout tests when virtual-viewport is enabled. There are two fixes in this patch. The first is using the pinch viewport's root layer when building a layer tree for printing in text. In virtual viewport mode, the RenderLayerCompositor is no longer at the top of the hierarchy as PinchViewport inserts layers above it. This caused exceptions in devtools.js as layers were referencing parent layer id's that weren't passed down. The second is giving the transform layer in PinchViewport a name so that the ASSERT_NOT_REACHED isn't triggered. BUG=148816 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M Source/core/frame/PinchViewport.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.cpp View 4 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bokan
dgozman@ for Source/core/inspector vollick@ for PinchViewport.cpp
6 years, 1 month ago (2014-10-30 14:13:33 UTC) #2
dgozman
I'll defer to caseq@ for inspector part.
6 years, 1 month ago (2014-10-30 14:19:48 UTC) #4
caseq
inspector/ lgtm (+pfeldman for OWNER's stamp)
6 years, 1 month ago (2014-10-31 13:44:34 UTC) #6
Ian Vollick
lgtm
6 years, 1 month ago (2014-10-31 13:58:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684373003/1
6 years, 1 month ago (2014-10-31 13:59:09 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 15:00:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184736

Powered by Google App Engine
This is Rietveld 408576698