Mac: Use Mavericks occlusion APIs for power savings.

Mac: Use Mavericks occlusion APIs for power savings.

Use NSWindowDidChangeOcclusionStateNotification (new in 10.9
Mavericks) to detect when the application is hidden, the window is
minimized or obscured by another window.

Send the WasHidden to the WebContentsImpl, because this will
take into account tab capture.

When RenderWidgetHostViewMac::WasHidden is called, the previous
behavior was to destroy the BrowserCompositorViewMac. This has
the undesirable effect of creating a white flash when a hidden
window is re-exposed.

To prevent this, only destroy the BrowserCompositorViewMac when
the the RenderWidgetHostViewMac is removed from all NSWindows.
Manage the state of BrowserCompositorViewMac explicitly as being
Active (previously whenever it existed), Suspended (the new state
where it is kept around, but the RWH and DFH are hidden), and
Destroyed (previously wherever it did not exist).

Move some 10.7 APIs to base because they belong there, not in
content.

BUG=310374
Committed: https://crrev.com/044d85df5e5e3fbf5d826c694ebf5d4bca7706ce
Cr-Commit-Position: refs/heads/master@{#302160}

[ccameron, 2014-10-29 22:26:11]

ccameron@chromium.org changed reviewers:
+ andresantoso@chromium.org, miu@chromium.org

[ccameron, 2014-10-29 23:33:43]

This is Andre's patch from https://codereview.chromium.org/666123003/, with some
additional work added to RenderWidgetHostViewMac to avoid flashes when
re-exposing content.

[Andre, 2014-10-30 03:19:26]

https://codereview.chromium.org/684343002/diff/40001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_mac.h (right):

https://codereview.chromium.org/684343002/diff/40001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_mac.h:396: // - This
happens when |cocoa_view_| is occluded by another window. The
Occlusion also happens when the window is minimized, and when the app is hidden.

[miu, 2014-10-30 18:33:44]

lgtm

https://codereview.chromium.org/684343002/diff/40001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_mac.h (right):

https://codereview.chromium.org/684343002/diff/40001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_mac.h:402: //  
|delegated_frame_host_| has been hidden. This is for situations where
s/This is for situations where//

[ccameron, 2014-10-30 19:23:33]

ccameron@chromium.org changed reviewers:
+ avi@chromium.org

[ccameron, 2014-10-30 19:23:33]

Thanks!

Adding avi for base review.

https://codereview.chromium.org/684343002/diff/40001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_mac.h (right):

https://codereview.chromium.org/684343002/diff/40001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_mac.h:396: // - This
happens when |cocoa_view_| is occluded by another window. The
On 2014/10/30 03:19:26, Andre wrote:
> Occlusion also happens when the window is minimized, and when the app is
hidden.

Done.

https://codereview.chromium.org/684343002/diff/40001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_mac.h:402: //  
|delegated_frame_host_| has been hidden. This is for situations where
On 2014/10/30 18:33:44, miu wrote:
> s/This is for situations where//

Done.

[Avi (use Gerrit), 2014-10-30 19:32:52]

lgtm

https://codereview.chromium.org/684343002/diff/40001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_mac.h (right):

https://codereview.chromium.org/684343002/diff/40001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_mac.h:408: };
I love these comments.

https://codereview.chromium.org/684343002/diff/40001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/684343002/diff/40001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_mac.mm:3089: // If the
RenderWidgetHostViewCocoa is being removed its window, tear down
s/removed its/removed from its/

https://codereview.chromium.org/684343002/diff/40001/content/browser/web_cont...
File content/browser/web_contents/web_contents_view_mac.mm (right):

https://codereview.chromium.org/684343002/diff/40001/content/browser/web_cont...
content/browser/web_contents/web_contents_view_mac.mm:624: }
Perhaps it is simpler to do:

if (supportsOcclusionAPIs) {
  if (oldWindow) {
    // ... stuff
  }
  if (newWindow) {
    // ... stuff
  }
}

[ccameron, 2014-10-30 19:52:11]

Thanks!

https://codereview.chromium.org/684343002/diff/40001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/684343002/diff/40001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_mac.mm:3089: // If the
RenderWidgetHostViewCocoa is being removed its window, tear down
On 2014/10/30 19:32:52, Avi wrote:
> s/removed its/removed from its/

Done.

https://codereview.chromium.org/684343002/diff/40001/content/browser/web_cont...
File content/browser/web_contents/web_contents_view_mac.mm (right):

https://codereview.chromium.org/684343002/diff/40001/content/browser/web_cont...
content/browser/web_contents/web_contents_view_mac.mm:624: }
On 2014/10/30 19:32:52, Avi wrote:
> Perhaps it is simpler to do:
> 
> if (supportsOcclusionAPIs) {
>   if (oldWindow) {
>     // ... stuff
>   }
>   if (newWindow) {
>     // ... stuff
>   }
> }

Yeah, I was mirroring the function in RenderWidgetHostViewMac.

Done.

[ccameron, 2014-10-30 19:52:36]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-10-30 19:53:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/684343002/80001

[commit-bot: I haz the power, 2014-10-30 21:34:13]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-10-30 21:34:55]

Patchset 5 (id:??) landed as
https://crrev.com/044d85df5e5e3fbf5d826c694ebf5d4bca7706ce
Cr-Commit-Position: refs/heads/master@{#302160}