Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 684333002: Adding instrumentation to locate the source of jankiness. (Closed)

Created:
6 years, 1 month ago by vadimt
Modified:
6 years, 1 month ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding instrumentation to locate the source of jankiness. Previous instrumentations showed that TemplateURLService::ChangeToLoadedState alone is responsible for 2.74 janks per hour in UI thread in Win (8.15 on Mac). I need to instrument the code inside it to find out which part causes jank. This is a mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after. A number of similar CLs were landed, and none of them caused issues. They've helped to find and fix janky code. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers. BUG=422460 Committed: https://crrev.com/76e9fa8f84ecc98851451506072401be4f781c8f Cr-Commit-Position: refs/heads/master@{#302147}

Patch Set 1 #

Patch Set 2 : Rebasing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M components/search_engines/template_url_service.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vadimt
pkasting@, please provide OWNER's approval.
6 years, 1 month ago (2014-10-29 21:52:49 UTC) #2
Peter Kasting
LGTM
6 years, 1 month ago (2014-10-30 19:11:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684333002/20001
6 years, 1 month ago (2014-10-30 19:44:10 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-30 20:26:21 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 20:27:01 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76e9fa8f84ecc98851451506072401be4f781c8f
Cr-Commit-Position: refs/heads/master@{#302147}

Powered by Google App Engine
This is Rietveld 408576698