Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 684303002: Build and link SkCondVar in Chromium. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
mtklein, reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Build and link SkCondVar in Chromium. Chrome depends on SkMultiPictureDraw depends on SkTaskGroup depends on SkCondVar. BUG= Committed: https://crrev.com/9abcab9b27f12a5a253b33c2563a09ce3d17ffc6 Cr-Commit-Position: refs/heads/master@{#301969}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M skia/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M skia/skia_library.gypi View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mtklein
6 years, 1 month ago (2014-10-29 20:21:30 UTC) #2
reed1
lgtm
6 years, 1 month ago (2014-10-29 20:24:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684303002/1
6 years, 1 month ago (2014-10-29 20:24:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel/builds/4691)
6 years, 1 month ago (2014-10-29 21:01:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684303002/1
6 years, 1 month ago (2014-10-29 22:33:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 23:09:45 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 23:10:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9abcab9b27f12a5a253b33c2563a09ce3d17ffc6
Cr-Commit-Position: refs/heads/master@{#301969}

Powered by Google App Engine
This is Rietveld 408576698