Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 684293002: Add a version query string for the whispernet pnacl module. (Closed)

Created:
6 years, 1 month ago by rkc
Modified:
6 years, 1 month ago
Reviewers:
Charlie
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a version query string for the whispernet pnacl module. When updating Chrome, pNacl doesn't refresh the cached whispernet pNacl module leading to a stale version of the whispernet module being used with the the whispernet proxy extension. Adding a query parameter and reving it every time we check in a new version of the module will ensure that pNacl will consider the module a "new" file and will recreate its cache with it. The current version of the library corresponds to CL number 77701403. R=ckehoe@chromium.org BUG=428424 Committed: https://crrev.com/b9e9abc6393c0fe9bd9e662a899598e6e9efb8b5 Cr-Commit-Position: refs/heads/master@{#301960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M chrome/browser/resources/whispernet_proxy/whispernet_proxy.nmf.png View Binary file 0 comments Download
M chrome/browser/resources/whispernet_proxy/whispernet_proxy_pnacl.pexe.png View Binary file 0 comments Download

Messages

Total messages: 6 (1 generated)
rkc
6 years, 1 month ago (2014-10-29 19:25:44 UTC) #1
Charlie
lgtm
6 years, 1 month ago (2014-10-29 21:25:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684293002/1
6 years, 1 month ago (2014-10-29 21:29:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 22:57:29 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 22:58:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9e9abc6393c0fe9bd9e662a899598e6e9efb8b5
Cr-Commit-Position: refs/heads/master@{#301960}

Powered by Google App Engine
This is Rietveld 408576698