Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: components/copresence/public/copresence_delegate.h

Issue 684273004: Moving the DirectiveHandler to be owned by CopresenceManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing crash Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/copresence/handlers/directive_handler.cc ('k') | components/copresence/rpc/rpc_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/copresence/public/copresence_delegate.h
diff --git a/components/copresence/public/copresence_delegate.h b/components/copresence/public/copresence_delegate.h
index 9dd30b7285029e280984610f1b7a3f69849fe30a..64371d564d123cb6d73cba0ed46216f6fb8dc2c1 100644
--- a/components/copresence/public/copresence_delegate.h
+++ b/components/copresence/public/copresence_delegate.h
@@ -29,13 +29,14 @@ class CopresenceDelegate {
public:
virtual ~CopresenceDelegate() {}
- // This method will be called when we have subscribed messages that need to
- // be sent to their respective apps.
+ // This method will be called when we have subscribed messages
+ // that need to be sent to their respective apps.
virtual void HandleMessages(
const std::string& app_id,
const std::string& subscription_id,
const std::vector<Message>& message) = 0;
+ // Thw URLRequestContextGetter must outlive the CopresenceManager.
virtual net::URLRequestContextGetter* GetRequestContext() const = 0;
virtual const std::string GetPlatformVersionString() const = 0;
@@ -43,6 +44,7 @@ class CopresenceDelegate {
virtual const std::string GetAPIKey(const std::string& app_id) const = 0;
virtual const std::string GetAuthToken() const = 0;
+ // Thw WhispernetClient must outlive the CopresenceManager.
virtual WhispernetClient* GetWhispernetClient() = 0;
};
« no previous file with comments | « components/copresence/handlers/directive_handler.cc ('k') | components/copresence/rpc/rpc_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698