cc/layers/picture_layer_impl.cc - Issue 684273003: cc: Fix picture layer impl not to create a tiling with invalid size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/picture_layer_impl.cc

Issue 684273003: cc: Fix picture layer impl not to create a tiling with invalid size. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/picture_layer_impl.cc

diff --git a/cc/layers/picture_layer_impl.cc b/cc/layers/picture_layer_impl.cc

index c3c7ca021104ba5f2468b233838d45beee16c845..1dc139bc617cf1c1c015992b399e41b12de40983 100644

--- a/cc/layers/picture_layer_impl.cc

+++ b/cc/layers/picture_layer_impl.cc

@@ -902,8 +902,7 @@ PictureLayerTiling* PictureLayerImpl::AddTiling(float contents_scale) {

DCHECK(CanHaveTilingWithScale(contents_scale)) <<

"contents_scale: " << contents_scale;

- PictureLayerTiling* tiling =

- tilings_->AddTiling(contents_scale, pile_->tiling_size());

+ PictureLayerTiling* tiling = tilings_->AddTiling(contents_scale, bounds());

danakj 2014/10/30 17:27:09 I don't think this is the right answer. If a layer

DCHECK(pile_->HasRecordings());

« no previous file with comments | « no previous file | no next file » | no next file with comments »