Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 684273003: cc: Fix picture layer impl not to create a tiling with invalid size. (Closed)

Created:
6 years, 1 month ago by USE eero AT chromium.org
Modified:
6 years, 1 month ago
Reviewers:
danakj, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Fix perftest not to create infinite pile and tiling. Picture layer impl has been changed to use pile tiling size as layer bounds while creating picture layer tilings. Therefore, perftests should not create inifinite piles as they result in picture layer impls creating infinite tilings which exhaust memory. BUG=428844 Committed: https://crrev.com/f0d244108190fd3352db49a27b8b57db7ad9fe13 Cr-Commit-Position: refs/heads/master@{#302627}

Patch Set 1 #

Total comments: 1

Patch Set 2 : (Not a) Rebase #

Patch Set 3 : Reimplementation #

Total comments: 2

Patch Set 4 : Use a local variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M cc/resources/tile_manager_perftest.cc View 1 2 3 4 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
USE eero AT chromium.org
PTAL. I'm not sure if this issue should be fixed in picture layer impl or ...
6 years, 1 month ago (2014-10-30 17:25:24 UTC) #2
danakj
https://codereview.chromium.org/684273003/diff/1/cc/layers/picture_layer_impl.cc File cc/layers/picture_layer_impl.cc (right): https://codereview.chromium.org/684273003/diff/1/cc/layers/picture_layer_impl.cc#newcode905 cc/layers/picture_layer_impl.cc:905: PictureLayerTiling* tiling = tilings_->AddTiling(contents_scale, bounds()); I don't think this ...
6 years, 1 month ago (2014-10-30 17:27:09 UTC) #3
USE eero AT chromium.org
On 2014/10/30 17:27:09, danakj wrote: > I don't think this is the right answer. OK. ...
6 years, 1 month ago (2014-10-30 17:40:30 UTC) #4
danakj
On Thu, Oct 30, 2014 at 1:40 PM, <e.hakkinen@samsung.com> wrote: > On 2014/10/30 17:27:09, danakj ...
6 years, 1 month ago (2014-10-30 18:05:17 UTC) #5
USE eero AT chromium.org
On 2014/10/30 18:05:17, danakj wrote: > Ya ok, figures. Make it create a pile the ...
6 years, 1 month ago (2014-11-04 15:25:40 UTC) #6
danakj
https://codereview.chromium.org/684273003/diff/40001/cc/resources/tile_manager_perftest.cc File cc/resources/tile_manager_perftest.cc (right): https://codereview.chromium.org/684273003/diff/40001/cc/resources/tile_manager_perftest.cc#newcode362 cc/resources/tile_manager_perftest.cc:362: Cool, this looks good. But one thing: how about ...
6 years, 1 month ago (2014-11-04 15:39:55 UTC) #7
USE eero AT chromium.org
https://codereview.chromium.org/684273003/diff/40001/cc/resources/tile_manager_perftest.cc File cc/resources/tile_manager_perftest.cc (right): https://codereview.chromium.org/684273003/diff/40001/cc/resources/tile_manager_perftest.cc#newcode362 cc/resources/tile_manager_perftest.cc:362: On 2014/11/04 15:39:55, danakj wrote: > Cool, this looks ...
6 years, 1 month ago (2014-11-04 16:00:35 UTC) #8
danakj
LGTM
6 years, 1 month ago (2014-11-04 16:05:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684273003/60001
6 years, 1 month ago (2014-11-04 16:06:42 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-11-04 18:13:45 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 18:14:29 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f0d244108190fd3352db49a27b8b57db7ad9fe13
Cr-Commit-Position: refs/heads/master@{#302627}

Powered by Google App Engine
This is Rietveld 408576698