Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 684243002: Fix chrome/ and content/ builds in Windows + BoringSSL. (Closed)

Created:
6 years, 1 month ago by davidben
Modified:
6 years, 1 month ago
Reviewers:
eroman, Dan Beam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@nacl-fix
Project:
chromium
Visibility:
Public.

Description

Fix chrome/ and content/ builds in Windows + BoringSSL. MSVC doensn't like zero-size arrays. Also, the analog of USE_NSS is USE_OPENSSL_CERTS, not USE_OPENSSL; CertificateViewerUI shouldn't be built on Windows as we use the system one. BUG=338884 Committed: https://crrev.com/acd2dc568b06a2e6992802e4709c66fe6cc1d57e Cr-Commit-Position: refs/heads/master@{#301956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/webcrypto/openssl/hmac_openssl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
davidben
dbeam: chrome/ eroman: content/
6 years, 1 month ago (2014-10-29 16:59:56 UTC) #2
Dan Beam
lgtm
6 years, 1 month ago (2014-10-29 19:08:19 UTC) #3
eroman
lgtm
6 years, 1 month ago (2014-10-29 20:36:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684243002/1
6 years, 1 month ago (2014-10-29 21:18:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 22:48:16 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 22:49:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/acd2dc568b06a2e6992802e4709c66fe6cc1d57e
Cr-Commit-Position: refs/heads/master@{#301956}

Powered by Google App Engine
This is Rietveld 408576698