Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_params.h

Issue 684223003: Data Reduction Proxy Interstitials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h b/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
index ade942dac9439f2dcf3dcf4b49f63ef3ab1e09e0..8d94348af9c04de1c562a1eb010abff35ad17b11 100644
--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
@@ -90,6 +90,10 @@ class DataReductionProxyParams {
// the data reduction proxy via header is missing.
static bool IsIncludedInRemoveMissingViaHeaderOtherBypassFieldTrial();
+ // Returns true if this client is part of field trial to show bypass warnings
+ // for the data reduction proxy.
+ static bool IsIncludedInBypassWarningTrial();
+
// Constructs configuration parameters. If |kAllowed|, then the standard
// data reduction proxy configuration is allowed to be used. If
// |kfallbackAllowed| a fallback proxy can be used if the primary proxy is
@@ -142,11 +146,10 @@ class DataReductionProxyParams {
// Checks if all configured data reduction proxies are in the retry map.
// Returns true if the request is bypassed by all configured data reduction
- // proxies that apply to the request scheme. If all possible data reduction
- // proxies are bypassed, returns the minimum retry delay of the bypassed data
- // reduction proxies in min_retry_delay (if not NULL). If there are no
- // bypassed data reduction proxies for the request scheme, returns false and
- // does not assign min_retry_delay.
+ // proxies and returns the bypass delay in delay_seconds (if not NULL). If
+ // there are no configured data reduction proxies, returns false. If
+ // the request is bypassed by more than one proxy, delay_seconds returns
+ // the shortest delay.
bool AreDataReductionProxiesBypassed(const net::URLRequest& request,
base::TimeDelta* min_retry_delay) const;

Powered by Google App Engine
This is Rietveld 408576698