Data Reduction Proxy Interstitials

components/data_reduction_proxy/content/browser/data_reduction_proxy_ui_service.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_DATA_REDUCTION_PROXY_CONTENT_DATA_REDUCTION_PROXY_UI_SERVICE_H_
+#define COMPONENTS_DATA_REDUCTION_PROXY_CONTENT_DATA_REDUCTION_PROXY_UI_SERVICE_H_
+
+#include "base/memory/scoped_ptr.h"

[bengr, 2014/12/29 18:45:42]

Not needed. But you do need "base/memory/ref_counted.h"

[megjablon, 2014/12/30 23:40:01]

Done.

+#include "components/data_reduction_proxy/content/browser/data_reduction_proxy_ui_manager.h"

[bengr, 2014/12/29 18:45:42]

Can this be forward declared?

[megjablon, 2014/12/30 23:40:01]

Done.

+
+namespace net {
+class ProxyConfig;
+}
+
+namespace data_reduction_proxy {
+
+class DataReductionProxyUIService {
+ public:
+  typedef base::Callback<const net::ProxyConfig&()> ProxyConfigGetter;

[bengr, 2014/12/29 18:45:42]

This is defined in DRPNetworkDelegate, no? If so, use that one.

[megjablon, 2014/12/30 23:40:01]

Done.

+
+  DataReductionProxyUIService();
+  virtual ~DataReductionProxyUIService();
+
+  void set_proxy_config_getter(const ProxyConfigGetter& getter);
+  // Virtual for testing.
+  virtual const net::ProxyConfig& data_reduction_proxy_config() const;
+
+  const scoped_refptr<DataReductionProxyUIManager>& ui_manager() const;

[bengr, 2014/12/29 18:45:42]

Do you really need a scoped_refptr? Would a scoped_ptr do instead?

[megjablon, 2014/12/30 23:40:01]

The ui manager is a ref counted object since we invoke one of its class methods
with base::Bind().

+
+ private:
+  // The UI manager handles showing interstitials. Accessed on both UI and IO
+  // thread.
+  scoped_refptr<DataReductionProxyUIManager> ui_manager_;
+  ProxyConfigGetter proxy_config_getter_;

[bengr, 2014/12/29 18:45:42]

#include DRPNetworkDelegate

[megjablon, 2014/12/30 23:40:01]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(DataReductionProxyUIService);
+};
+
+}  // namespace data_reduction_proxy
+
+#endif  // COMPONENTS_DATA_REDUCTION_PROXY_CONTENT_DATA_REDUCTION_PROXY_UI_SERVICE_H_