Data Reduction Proxy Interstitials

components/data_reduction_proxy/content/browser/data_reduction_proxy_resource_throttle.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/data_reduction_proxy/content/browser/data_reduction_proxy_resource_throttle.h"
+
+#include "components/data_reduction_proxy/content/browser/data_reduction_proxy_ui_service.h"
+#include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/resource_controller.h"
+#include "content/public/browser/resource_request_info.h"
+#include "net/base/load_flags.h"
+#include "net/http/http_response_headers.h"
+#include "net/url_request/url_request.h"
+
+namespace data_reduction_proxy {
+
+namespace {
+
+const char kResouceThrottleLogName[] = "DataReductionProxyResourceThrottle";
+
+}  // namespace
+
+DataReductionProxyResourceThrottle::DataReductionProxyResourceThrottle(
+    const net::URLRequest* request,
+    content::ResourceType resource_type,
+    const DataReductionProxyUIService* ui_service,
+    const DataReductionProxyParams* params)
+    : state_(NOT_BYPASSED),
+      request_(request),
+      ui_service_(ui_service),
+      params_(params),
+      is_subresource_(resource_type != content::RESOURCE_TYPE_MAIN_FRAME) {
+  DCHECK(request);
+  DCHECK(ui_service);
+  DCHECK(params);
+}
+
+DataReductionProxyResourceThrottle::~DataReductionProxyResourceThrottle() {
+}
+
+void DataReductionProxyResourceThrottle::WillStartUsingNetwork(bool* defer) {
+  DCHECK(state_ == NOT_BYPASSED);
+  if (!params_->AreDataReductionProxiesBypassed(*request_, NULL))
+    return;
+
+  if (request_->load_flags() & net::LOAD_PREFETCH) {
+    // Don't prefetch resources that bypass, disallow them.
+    controller()->Cancel();
+    return;
+  }
+
+  if (params_->IsBypassedByDataReductionProxyLocalRules(
+      *request_, ui_service_->data_reduction_proxy_config())) {
+    state_ = LOCAL_BYPASS;
+    return;
+  }
+

[bengr, 2014/12/29 18:45:41]

This blank line and others in your methods aren't needed. Consider removing some
or all of them, but leave them in when you think they improve readability.

[megjablon, 2014/12/30 23:39:59]

Done.

+  DisplayBlockingPage(defer);
+}
+
+void DataReductionProxyResourceThrottle::WillRedirectRequest(
+    const GURL& new_url,
+    bool* defer) {
+  // If we have already shown the interstitial, do not show it again. The
+  // LOAD_BYPASS_PROXY flag makes it so that we do not resolve proxies. This
+  // override is used when downloading PAC files. If the request does not have
+  // the LOAD_BYPASS_PROXY flag, do not show the interstitial.
+  if (state_ != NOT_BYPASSED ||
+      !(request_->load_flags() & net::LOAD_BYPASS_PROXY)) {
+    return;
+  }
+
+  DisplayBlockingPage(defer);
+}
+
+void DataReductionProxyResourceThrottle::WillProcessResponse(bool* defer) {
+  if (state_ != NOT_BYPASSED)
+    return;
+
+  if (params_->IsDataReductionProxy(request_->proxy_server(), NULL) ||

[bengr, 2014/12/29 18:45:41]

I don't understand this. You proceed if the proxy is DRP *or* its a scheme the
DRP can't proxy? Why?

[megjablon, 2014/12/30 23:39:59]

Acknowledged.

+      !request_->url().SchemeIs("http")) {

[bengr, 2014/12/29 18:45:41]

The checks against the scheme are brittle, because the DRP may eventually proxy
other schemes. Suggest adding a static to DRPParams called 'bool
CanProxyURLScheme(const GURL& url);'

[megjablon, 2014/12/30 23:39:59]

Done.

+    return;
+  }
+
+  DisplayBlockingPage(defer);
+}
+
+void DataReductionProxyResourceThrottle::DisplayBlockingPage(bool* defer) {
+  const content::ResourceRequestInfo* info =
+      content::ResourceRequestInfo::ForRequest(request_);
+  DCHECK(info);
+
+  state_ = REMOTE_BYPASS;
+  DataReductionProxyUIManager::BypassResource resource;
+  resource.url = request_->url();
+  resource.is_subresource = is_subresource_;
+  resource.callback = base::Bind(
+      &DataReductionProxyResourceThrottle::OnBlockingPageComplete, AsWeakPtr());
+  resource.render_process_host_id = info->GetChildID();
+  resource.render_view_id = info->GetRouteID();
+
+  *defer = true;
+
+  content::BrowserThread::PostTask(
+      content::BrowserThread::UI, FROM_HERE,
+      base::Bind(
+          &DataReductionProxyResourceThrottle::StartDisplayingBlockingPage,
+          AsWeakPtr(), ui_service_->ui_manager(), resource));
+}
+
+const char* DataReductionProxyResourceThrottle::GetNameForLogging() const {
+    return kResouceThrottleLogName;
+}
+
+// static
+void DataReductionProxyResourceThrottle::StartDisplayingBlockingPage(

[bengr, 2014/12/29 18:45:41]

Make sure the definition order matches the declaration order.

[megjablon, 2014/12/30 23:39:59]

Done.

+    const base::WeakPtr<DataReductionProxyResourceThrottle>& throttle,
+    scoped_refptr<DataReductionProxyUIManager> ui_manager,
+    const DataReductionProxyUIManager::BypassResource& resource) {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+  ui_manager->DisplayBlockingPage(resource);
+}
+
+void DataReductionProxyResourceThrottle::OnBlockingPageComplete(bool proceed) {
+  state_ = NOT_BYPASSED;
+  if (proceed)
+    controller()->Resume();
+  else
+    controller()->Cancel();
+}
+
+}  // namespace data_reduction_proxy