Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: src/gpu/GrClipMaskManager.h

Issue 684223002: cleanup reentrance logic in CMM (Closed) Base URL: https://skia.googlesource.com/skia.git@drawtarget_on_clip_manager
Patch Set: feedback inc Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/GrClipMaskManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrClipMaskManager.h
diff --git a/src/gpu/GrClipMaskManager.h b/src/gpu/GrClipMaskManager.h
index e4d7223c7e0cdc807d795da5f40020e5b39bb2e3..c38e1405b08e5f09b1e7c5354d7fb0eac88217bb 100644
--- a/src/gpu/GrClipMaskManager.h
+++ b/src/gpu/GrClipMaskManager.h
@@ -40,7 +40,8 @@ class GrClipMaskManager : SkNoncopyable {
public:
GrClipMaskManager()
: fCurrClipMaskType(kNone_ClipMaskType)
- , fClipTarget(NULL) {
+ , fClipTarget(NULL)
+ , fClipMode(kIgnoreClip_StencilClipMode) {
}
// The state of the scissor is controlled by the clip manager, no one else should set
@@ -94,14 +95,6 @@ public:
void adjustPathStencilParams(GrStencilSettings*);
private:
- enum PrivateDrawStateStateBits {
- kFirstBit = (GrDrawState::kLastPublicStateBit << 1),
-
- kModifyStencilClip_StateBit = kFirstBit, // allows draws to modify
- // stencil bits used for
- // clipping.
- };
-
/**
* Informs the helper function adjustStencilParams() about how the stencil
* buffer clip is being used.
@@ -202,7 +195,8 @@ private:
} fCurrClipMaskType;
GrClipMaskCache fAACache; // cache for the AA path
- GrClipTarget* fClipTarget;
+ GrClipTarget* fClipTarget;
+ StencilClipMode fClipMode;
typedef SkNoncopyable INHERITED;
};
« no previous file with comments | « no previous file | src/gpu/GrClipMaskManager.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698