Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 684203003: Update GrTRecorder to preserve memory allocations (Closed)

Created:
6 years, 1 month ago by Chris Dalton
Modified:
6 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Update GrTRecorder to preserve memory allocations Rather than freeing almost all of its memory on calls to reset(), this change updates GrTRecorder so it keeps around enough to satisfy the storage requirements from last time, plus up to ~50% growth. This is based on the assumption that subsequent draw calls require roughly the same amount of memory. BUG=skia: Committed: https://skia.googlesource.com/skia/+/c4650ee786f1420f548bcc33b207b83244474351

Patch Set 1 #

Patch Set 2 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M src/gpu/GrInOrderDrawBuffer.h View 1 1 chunk +1 line, -1 line 2 comments Download
M src/gpu/GrTRecorder.h View 3 chunks +22 lines, -8 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
Chris Dalton
https://codereview.chromium.org/684203003/diff/20001/src/gpu/GrInOrderDrawBuffer.h File src/gpu/GrInOrderDrawBuffer.h (right): https://codereview.chromium.org/684203003/diff/20001/src/gpu/GrInOrderDrawBuffer.h#newcode304 src/gpu/GrInOrderDrawBuffer.h:304: kCmdBufferInitialSizeInBytes = 8 * 1024, This was arbitrary. The ...
6 years, 1 month ago (2014-11-07 19:38:47 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/684203003/diff/20001/src/gpu/GrInOrderDrawBuffer.h File src/gpu/GrInOrderDrawBuffer.h (right): https://codereview.chromium.org/684203003/diff/20001/src/gpu/GrInOrderDrawBuffer.h#newcode304 src/gpu/GrInOrderDrawBuffer.h:304: kCmdBufferInitialSizeInBytes = 8 * 1024, On 2014/11/07 19:38:47, ...
6 years, 1 month ago (2014-11-07 20:06:42 UTC) #3
Chris Dalton
https://codereview.chromium.org/684203003/diff/20001/src/gpu/GrTRecorder.h File src/gpu/GrTRecorder.h (right): https://codereview.chromium.org/684203003/diff/20001/src/gpu/GrTRecorder.h#newcode223 src/gpu/GrTRecorder.h:223: // Assume the next time this recorder fills up ...
6 years, 1 month ago (2014-11-07 20:42:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684203003/20001
6 years, 1 month ago (2014-11-07 20:43:41 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 20:51:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c4650ee786f1420f548bcc33b207b83244474351

Powered by Google App Engine
This is Rietveld 408576698