Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: pkg/analysis_server/lib/src/services/completion/invocation_computer.dart

Issue 684183002: Refactor CompletionSuggestionKind (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart b/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
index 3669bd43ddb62d6915128eae3cdfdb9e2a58d404..9b912055277fda49244d59ca8decedd028a0f8c3 100644
--- a/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
+++ b/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
@@ -12,6 +12,8 @@ import 'package:analyzer/src/generated/ast.dart';
import 'package:analyzer/src/generated/element.dart';
import 'package:analyzer/src/generated/scanner.dart';
+import '../../protocol_server.dart' show CompletionSuggestionKind;
+
/**
* A computer for calculating invocation / access suggestions
* `completion.getSuggestions` request results.
@@ -140,7 +142,10 @@ class _InvocationElementVisitor extends GeneralizingElementVisitor<Future<bool>>
if (element != null) {
InterfaceType type = element.type;
if (type != null) {
- ClassElementSuggestionBuilder.staticSuggestionsFor(request, type.element);
+ ClassElementSuggestionBuilder.suggestionsFor(
+ request,
+ type.element,
+ staticOnly: true);
}
}
return new Future.value(false);
@@ -163,7 +168,10 @@ class _InvocationElementVisitor extends GeneralizingElementVisitor<Future<bool>>
if (directive.prefix.name == element.name) {
// Suggest elements from the imported library
LibraryElement library = directive.uriElement;
- LibraryElementSuggestionBuilder.suggestionsFor(request, library);
+ LibraryElementSuggestionBuilder.suggestionsFor(
+ request,
+ CompletionSuggestionKind.INVOCATION,
+ library);
modified = true;
}
}

Powered by Google App Engine
This is Rietveld 408576698