Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 684173004: Add test for RemoveEntryAtIndex in the pending case. (Closed)

Created:
6 years, 1 month ago by Charlie Reis
Modified:
6 years, 1 month ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add test for RemoveEntryAtIndex in the pending case. This documents some possibly unexpected behavior, where the pending entry is cleared if it exists. BUG=428380 TEST=No behavior change. Committed: https://crrev.com/750ade3fa8cad705e9f522269fbc2fbb12ec184e Cr-Commit-Position: refs/heads/master@{#301989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3 lines) Patch
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M content/public/browser/navigation_controller.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie Reis
Just a bit of clarification, since I was surprised it wasn't buggy in this case.
6 years, 1 month ago (2014-10-29 18:51:04 UTC) #2
nasko
LGTM
6 years, 1 month ago (2014-10-29 21:26:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684173004/1
6 years, 1 month ago (2014-10-29 21:33:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 00:20:13 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 00:20:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/750ade3fa8cad705e9f522269fbc2fbb12ec184e
Cr-Commit-Position: refs/heads/master@{#301989}

Powered by Google App Engine
This is Rietveld 408576698