chrome/browser/ui/webui/options/browser_options_handler.cc - Issue 684143003: Make chrome/browser/ui/webui not depend on ash when using Athena

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 684143003: Make chrome/browser/ui/webui not depend on ash when using Athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@athena_do_not_use_ash43_kiosk_mode

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/chromeos/set_time_ui.cc ('k') | chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc » ('j') | chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/browser_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc

index e263ff3cc2256262d78e504bd8b600e9c81c3a72..627b91d1cf62b50293f0ee808c147cb6fe0793fa 100644

--- a/chrome/browser/ui/webui/options/browser_options_handler.cc

+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc

@@ -1705,7 +1705,9 @@ void BrowserOptionsHandler::HandleRefreshExtensionControlIndicators(

#if defined(OS_CHROMEOS)

void BrowserOptionsHandler::HandleOpenWallpaperManager(

const base::ListValue* args) {

+#if defined(USE_ASH)

ash::Shell::GetInstance()->user_wallpaper_delegate()->OpenSetWallpaperPage();

Evan Stade 2014/10/31 18:27:12 #else notimplemented? notreached?

pkotwicz 2014/10/31 19:07:58 Added NOTIMPLEMENTED() We will need to grep the c

+#endif

}

void BrowserOptionsHandler::VirtualKeyboardChangeCallback(