content/renderer/render_frame_impl.cc - Issue 684143002: Invalidate the previous frame when the window object is cleared.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 684143002: Invalidate the previous frame when the window object is cleared. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DCHECK_EQ(frame_, frame) -> DCHECK again Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | extensions/renderer/script_injection_manager.cc » ('j') | extensions/renderer/script_injection_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 7d23a41e54ea4897861127b498eea355968a1643..7f59bf64160973e6ec93e58f070433c3c5354808 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -2387,6 +2387,13 @@ void RenderFrameImpl::didCommitProvisionalLoad(

UpdateEncoding(frame, frame->view()->pageEncoding().utf8());

}

+void RenderFrameImpl::didCreateNewDocument(blink::WebLocalFrame* frame) {

+ DCHECK(!frame_ || frame_ == frame);

+ FOR_EACH_OBSERVER(RenderViewObserver, render_view_->observers(),

+ DidCreateNewDocument(frame));

void RenderFrameImpl::didClearWindowObject(blink::WebLocalFrame* frame) {

DCHECK(!frame_ || frame_ == frame);

// TODO(nasko): Move implementation here. Needed state:

« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | extensions/renderer/script_injection_manager.cc » ('j') | extensions/renderer/script_injection_manager.cc » ('J')