content/public/renderer/render_view_observer.h - Issue 684143002: Invalidate the previous frame when the window object is cleared.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/renderer/render_view_observer.h

Issue 684143002: Invalidate the previous frame when the window object is cleared. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DCHECK_EQ(frame_, frame) -> DCHECK again Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/test_file_with_javascript_url_iframe.html ('k') | content/renderer/render_frame_impl.h » ('j') | extensions/renderer/script_injection_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/renderer/render_view_observer.h

diff --git a/content/public/renderer/render_view_observer.h b/content/public/renderer/render_view_observer.h

index 4c7aba0529f4b275e4dcbb1e4e755fd690407832..0100324edced9210f28d5f09e00972b3a6e19714 100644

--- a/content/public/renderer/render_view_observer.h

+++ b/content/public/renderer/render_view_observer.h

@@ -11,6 +11,7 @@

#include "ipc/ipc_listener.h"

#include "ipc/ipc_sender.h"

#include "third_party/WebKit/public/platform/WebVector.h"

+#include "v8/include/v8.h"

class GURL;

@@ -61,6 +62,7 @@ class CONTENT_EXPORT RenderViewObserver : public IPC::Listener,

const blink::WebURLError& error) {}

virtual void DidCommitProvisionalLoad(blink::WebLocalFrame* frame,

bool is_new_navigation) {}

+ virtual void DidCreateNewDocument(blink::WebLocalFrame* frame) {}

virtual void DidClearWindowObject(blink::WebLocalFrame* frame) {}

virtual void DidCreateDocumentElement(blink::WebLocalFrame* frame) {}

virtual void FrameCreated(blink::WebLocalFrame* parent,