chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/manifest.json - Issue 684143002: Invalidate the previous frame when the window object is cleared.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/manifest.json

Issue 684143002: Invalidate the previous frame when the window object is cleared. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DCHECK_EQ(frame_, frame) -> DCHECK again Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/end.js ('k') | chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/start.js » ('j') | extensions/renderer/script_injection_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/manifest.json

diff --git a/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/manifest.json b/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/manifest.json

index b591cb21a3d66f52f6d7a300664e480c4d42d4f0..5f33dcd90d7529141ec4a9e1aed40f8957d40b3e 100644

--- a/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/manifest.json

+++ b/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/manifest.json

@@ -9,7 +9,9 @@

"permissions": ["tabs"],

"content_scripts": [

{

+ "run_at": "document_end",

"matches": ["http://*/*"],

+ "exclude_matches": ["http://*/*test_file_with_javascript_url*"],

"js": ["content_script.js"],

"all_frames": true

@@ -19,6 +21,20 @@

"match_about_blank": true,

"js": ["content_script2.js"],

"all_frames": true

+ },

+ {

+ "run_at": "document_start",

+ "matches": ["http://*/*test_file_with_javascript_url*"],

+ "match_about_blank": true,

+ "js": ["start.js"],

+ "all_frames": true

+ },

+ {

+ "run_at": "document_end",

+ "matches": ["http://*/*test_file_with_javascript_url*"],

+ "match_about_blank": true,

+ "js": ["end.js"],

+ "all_frames": true

}

]

}