Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 684133005: Revert of cc: Make Overlay unit tests work when sync query extension is available. (Closed)

Created:
6 years, 1 month ago by reveman
Modified:
6 years, 1 month ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Make Overlay unit tests work when sync query extension is available. (patchset #1 id:1 of https://codereview.chromium.org/669233003/) Reason for revert: Not properly reviewed. Original issue's description: > cc: Make Overlay unit tests work when sync query extension is available. > > GLRenderer expects a BeginDrawingFrame before each > FinishDrawingFrame call. > > This also makes sure GLRenderer::BeginDrawingFrame doesn't > early out before creating the read lock fence. > > BUG=428071 > TBR=danakj > TEST=cc_unittests --gtest_filter=GLRendererWithOverlaysTest.ResourcesExportedAndReturned > > Committed: https://crrev.com/c9260a0912dfe55fb38f5d85f954a021d9a8d626 > Cr-Commit-Position: refs/heads/master@{#301775} TBR=danakj@chromium.org,alexst@chromium.org NOTREECHECKS=true NOTRY=true BUG=428071 Committed: https://crrev.com/9de4795a9852e92a2613349b139fe6ec07f14d13 Cr-Commit-Position: refs/heads/master@{#301840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -14 lines) Patch
M cc/output/gl_renderer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/output/overlay_unittest.cc View 7 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reveman
Created Revert of cc: Make Overlay unit tests work when sync query extension is available.
6 years, 1 month ago (2014-10-29 15:35:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684133005/1
6 years, 1 month ago (2014-10-29 15:36:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 15:37:22 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 15:38:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9de4795a9852e92a2613349b139fe6ec07f14d13
Cr-Commit-Position: refs/heads/master@{#301840}

Powered by Google App Engine
This is Rietveld 408576698