Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 684113003: Docserver: Default to master commit ID on refresh (Closed)

Created:
6 years, 1 month ago by Ken Rockot(use gerrit already)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Docserver: Default to master commit ID on refresh Currently _refresh handler caches data uses tip of tree and caches data under the remote's master commit ID if run without a 'commit' paramter. This CL changes the handler to use the last cached 'master' commit ID instead, so that refresh tasks for non-chromium-git data can be run between refresh cycles. BUG=None R=kalman@chromium.org NOTRY=True Committed: https://crrev.com/10e7c0fd59ec70f46dd0df4f188d34c22960d502 Cr-Commit-Position: refs/heads/master@{#302635}

Patch Set 1 #

Patch Set 2 : rietveld logging #

Patch Set 3 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/common/extensions/docs/server2/app.yaml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/refresh_servlet.py View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/rietveld_patcher.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Ken Rockot(use gerrit already)
ben could you take a look?
6 years, 1 month ago (2014-11-04 18:44:05 UTC) #1
not at google - send to devlin
lgtm though could you do me a favour and add a bit of logging to ...
6 years, 1 month ago (2014-11-04 18:47:30 UTC) #2
Ken Rockot(use gerrit already)
done
6 years, 1 month ago (2014-11-04 18:55:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684113003/40001
6 years, 1 month ago (2014-11-04 18:57:04 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-04 18:58:37 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 18:59:13 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/10e7c0fd59ec70f46dd0df4f188d34c22960d502
Cr-Commit-Position: refs/heads/master@{#302635}

Powered by Google App Engine
This is Rietveld 408576698