Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 684093008: command_buffer: Implement IdAllocator by recording ranges in an AVL tree

Created:
6 years, 1 month ago by Kimmo Kinnunen
Modified:
5 years, 9 months ago
Reviewers:
CC:
chromium-reviews, piman+watch_chromium.org, Chris Dalton, vbuzinov
Base URL:
https://chromium.googlesource.com/chromium/src.git@new-05-path-fragment-input-gen
Project:
chromium
Visibility:
Public.

Description

command_buffer: Implement IdAllocator by recording ranges in an AVL tree Implement IdAllocator by keeping track of used id ranges instead of individual ids. This should make allocating big amount of ids scale a bit better. Store the ranges in a tree where nodes store the range as closed interval (min, max). The tree is an AVL tree with the min entry as the key. All represented ranges are maximal, eg. if the node is in the tree, it represents the complete contiguous id range starting at |min| and ending at |max|, inclusive. BUG=344330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+427 lines, -124 lines) Patch
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/command_buffer/common/id_allocator.h View 2 chunks +22 lines, -12 lines 0 comments Download
M gpu/command_buffer/common/id_allocator.cc View 1 chunk +353 lines, -107 lines 0 comments Download
M gpu/command_buffer/common/id_allocator_test.cc View 2 chunks +51 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Kimmo Kinnunen
Alternative to https://codereview.chromium.org/692073002/ , maybe a bit more 'clean' in some sense. Using std::map was ...
6 years, 1 month ago (2014-10-31 13:59:21 UTC) #1
Kimmo Kinnunen
So I did this related to path rendering. This can be refactored to contain stuff ...
6 years, 1 month ago (2014-10-31 14:02:08 UTC) #3
David Yen
5 years, 9 months ago (2015-03-13 23:48:49 UTC) #5
On 2014/10/31 14:02:08, Kimmo Kinnunen wrote:
> So I did this related to path rendering. This can be refactored to contain
stuff
> only of interest without path rendering, if it would be useful to be reviewed
> before path rendering work. What would be useful is to understand which one is
> preferred: the one that uses std::map, this one with custom binary tree or
> nothing at all (abandon the patches)

Since the other CL has landed, should we close this one?

Powered by Google App Engine
This is Rietveld 408576698