Issue 684063002: Remove more frame-level scrolling machinery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 684063002: Remove more frame-level scrolling machinery. (Closed)

Created:
6 years, 1 month ago by ojan

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove more frame-level scrolling machinery. We don't need to know anymore whether the scroll was programmatic. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/41c50c28ed3a547e65b3de03824d69633df31758

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -68 lines)			Patch
M	sky/engine/core/frame/FrameView.h	View	4 chunks	+0 lines, -16 lines	0 comments	Download
M	sky/engine/core/frame/FrameView.cpp	View	5 chunks	+0 lines, -38 lines	0 comments	Download
M	sky/engine/core/page/EventHandler.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/page/EventHandler.cpp	View	5 chunks	+0 lines, -12 lines	1 comment	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

esprehn

lgtm https://codereview.chromium.org/684063002/diff/1/sky/engine/core/page/EventHandler.cpp File sky/engine/core/page/EventHandler.cpp (right): https://codereview.chromium.org/684063002/diff/1/sky/engine/core/page/EventHandler.cpp#newcode1483 sky/engine/core/page/EventHandler.cpp:1483: #define RETURN_WHEEL_EVENT_HANDLED() \ you should remove the macro, ...

6 years, 1 month ago (2014-10-29 03:06:48 UTC) #2

ojan

6 years, 1 month ago (2014-10-29 03:11:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
41c50c28ed3a547e65b3de03824d69633df31758 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages