Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 683933002: Introduce FeedbackNexus for vector-based ics. (Closed)

Created:
6 years, 1 month ago by mvstanton
Modified:
6 years, 1 month ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Introduce FeedbackNexus for vector-based ics. A FeedbackNexus is the combination of a feedback vector, a slot(s) in the vector, along with methods to query and manipulate that information in a type-correct way. A CallIC will have a CallICNexus, a LoadIC a LoadICNexus, etc., reflecting the fact that different types of ICs configure their data in unique ways. This CL limits itself to introducing and using the nexus type only for CallICs. A follow-up will use them for Load and KeyedLoadICs for the case when the --vector-ics flag is turned on. The notion of a Nexus is also embedded at the lowest level of the IC class. This makes sense because more ICs should become vector-based in the future. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+416 lines, -137 lines) Patch
M src/ic/ic.h View 10 chunks +48 lines, -24 lines 0 comments Download
M src/ic/ic.cc View 13 chunks +81 lines, -87 lines 0 comments Download
M src/ic/ic-inl.h View 1 chunk +1 line, -19 lines 0 comments Download
M src/ic/ic-state.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/ic-state.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/type-feedback-vector.h View 1 chunk +96 lines, -0 lines 0 comments Download
M src/type-feedback-vector.cc View 2 chunks +135 lines, -1 line 0 comments Download
M test/cctest/test-feedback-vector.cc View 2 chunks +45 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mvstanton
Hi Igor, Here is 2nd try, thanks for the help! The only change is in ...
6 years, 1 month ago (2014-10-28 15:54:21 UTC) #2
Igor Sheludko
lgtm
6 years, 1 month ago (2014-10-28 15:59:06 UTC) #3
mvstanton
6 years, 1 month ago (2014-10-28 16:05:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24952 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698