Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 683923003: [WebSocket] Add NOINLINE function calls to see the stack trace. (Closed)

Created:
6 years, 1 month ago by yhirano
Modified:
6 years, 1 month ago
Reviewers:
Adam Rice
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[WebSocket] Add NOINLINE function calls to see the stack trace. We have a crash bug related to redirection, but I couln't understand the mechanism so far. This CL adds some functions to see the actual path from the crash dump. BUG=399535 Committed: https://crrev.com/27b2b57ce6d4e03728b3addf305f00d114b32e19 Cr-Commit-Position: refs/heads/master@{#302069}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -4 lines) Patch
M net/websockets/websocket_basic_handshake_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_basic_handshake_stream.cc View 1 2 3 5 chunks +55 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
yhirano
6 years, 1 month ago (2014-10-30 05:07:48 UTC) #2
Adam Rice
https://codereview.chromium.org/683923003/diff/40001/net/websockets/websocket_basic_handshake_stream.cc File net/websockets/websocket_basic_handshake_stream.cc (right): https://codereview.chromium.org/683923003/diff/40001/net/websockets/websocket_basic_handshake_stream.cc#newcode50 net/websockets/websocket_basic_handshake_stream.cc:50: namespace { Please at a TODO to remove these ...
6 years, 1 month ago (2014-10-30 05:54:26 UTC) #3
yhirano
https://codereview.chromium.org/683923003/diff/40001/net/websockets/websocket_basic_handshake_stream.cc File net/websockets/websocket_basic_handshake_stream.cc (right): https://codereview.chromium.org/683923003/diff/40001/net/websockets/websocket_basic_handshake_stream.cc#newcode50 net/websockets/websocket_basic_handshake_stream.cc:50: namespace { On 2014/10/30 05:54:25, Adam Rice wrote: > ...
6 years, 1 month ago (2014-10-30 06:10:10 UTC) #4
Adam Rice
lgtm
6 years, 1 month ago (2014-10-30 07:22:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683923003/60001
6 years, 1 month ago (2014-10-30 07:29:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/17800)
6 years, 1 month ago (2014-10-30 08:05:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683923003/60001
6 years, 1 month ago (2014-10-30 11:01:47 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-10-30 11:23:55 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 11:24:36 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/27b2b57ce6d4e03728b3addf305f00d114b32e19
Cr-Commit-Position: refs/heads/master@{#302069}

Powered by Google App Engine
This is Rietveld 408576698