Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 683923002: Distance field path optimizations and clean up. (Closed)

Created:
6 years, 1 month ago by jvanverth1
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Distance field path optimizations and clean up. Adds the following: - Use cached geometry processor rather than recreating all the time. - Use context's quad index buffer. Committed: https://skia.googlesource.com/skia/+/6d22ecaa71cf4400feebc3438bf0e0dd68179500

Patch Set 1 #

Patch Set 2 : Rebase to ToT #

Total comments: 4

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -23 lines) Patch
M src/gpu/GrAADistanceFieldPathRenderer.h View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 5 chunks +15 lines, -17 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jvanverth1
6 years, 1 month ago (2014-10-28 15:51:29 UTC) #2
robertphillips
lgtm with 2 suggestions https://codereview.chromium.org/683923002/diff/20001/src/gpu/GrAADistanceFieldPathRenderer.h File src/gpu/GrAADistanceFieldPathRenderer.h (right): https://codereview.chromium.org/683923002/diff/20001/src/gpu/GrAADistanceFieldPathRenderer.h#newcode62 src/gpu/GrAADistanceFieldPathRenderer.h:62: SkAutoTUnref<GrGeometryProcessor> fCachedGeometryProcessor; // The flags ...
6 years, 1 month ago (2014-10-28 16:32:04 UTC) #3
jvanverth1
https://codereview.chromium.org/683923002/diff/20001/src/gpu/GrAADistanceFieldPathRenderer.h File src/gpu/GrAADistanceFieldPathRenderer.h (right): https://codereview.chromium.org/683923002/diff/20001/src/gpu/GrAADistanceFieldPathRenderer.h#newcode62 src/gpu/GrAADistanceFieldPathRenderer.h:62: SkAutoTUnref<GrGeometryProcessor> fCachedGeometryProcessor; On 2014/10/28 16:32:04, robertphillips wrote: > // ...
6 years, 1 month ago (2014-10-28 18:01:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683923002/40001
6 years, 1 month ago (2014-10-28 18:02:34 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 18:10:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 6d22ecaa71cf4400feebc3438bf0e0dd68179500

Powered by Google App Engine
This is Rietveld 408576698