third_party/zlib/google/zip_reader.h - Issue 683913009: Eliminate resource leaks from zip::ZipFiles and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/zlib/google/zip_reader.h

Issue 683913009: Eliminate resource leaks from zip::ZipFiles and (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/zlib/google/zip_reader.h

diff --git a/third_party/zlib/google/zip_reader.h b/third_party/zlib/google/zip_reader.h

index cda9cf7e15baab362cfabffddf9f22fa6882b09c..9280f23029ed9f4ed395ed6a8819a95fa5d91445 100644

--- a/third_party/zlib/google/zip_reader.h

+++ b/third_party/zlib/google/zip_reader.h

@@ -102,8 +102,8 @@ class ZipReader {

// success.

bool Open(const base::FilePath& zip_file_path);

- // Opens the zip file referred to by the platform file |zip_fd|.

- // Returns true on success.

+ // Opens the zip file referred to by the platform file |zip_fd|, without

+ // taking ownership of |zip_fd|. Returns true on success.

bool OpenFromPlatformFile(base::PlatformFile zip_fd);

// Opens the zip data stored in |data|. This class uses a weak reference to