Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 683913008: Turn ToNumberStub into a PlatformCodeStub again. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Turn ToNumberStub into a PlatformCodeStub again. The HydrogenCodeStub is too expensive and there's no easy way to reduce this cost, so turning it into a PlatformCodeStub solves that problem until we can use TurboFan for code stubs. TEST=mjsunit R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25187

Patch Set 1 #

Patch Set 2 : Use branches on ARM as well (better prediction). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -44 lines) Patch
M src/arm/code-stubs-arm.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/code-stubs.h View 4 chunks +10 lines, -10 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-11-06 11:30:41 UTC) #2
mvstanton
Yep, LGTM.
6 years, 1 month ago (2014-11-06 11:58:03 UTC) #4
Benedikt Meurer
6 years, 1 month ago (2014-11-06 12:02:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as 25187 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698