Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 683913005: [GCM] Support registration before unregistration finishes (Closed)

Created:
6 years, 1 month ago by jianli
Modified:
6 years, 1 month ago
Reviewers:
fgorski
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[GCM] Support registration before unregistration finishes This is to solve the problem that the app could be uninstalled and then reinstalled immediately. We do not want the app to encounter ASYNC_OPERATION_PENDING error. We now wait till the unregistration completes and then triggers the pending registration. BUG=371880 TEST=new test added Committed: https://crrev.com/f17b85ad7985ebf3685bfc9ac23895f29247f474 Cr-Commit-Position: refs/heads/master@{#301939}

Patch Set 1 #

Patch Set 2 : Add more comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -27 lines) Patch
M components/gcm_driver/gcm_driver.h View 3 chunks +10 lines, -3 lines 0 comments Download
M components/gcm_driver/gcm_driver.cc View 1 5 chunks +38 lines, -7 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop_unittest.cc View 3 chunks +23 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jianli
6 years, 1 month ago (2014-10-28 22:16:28 UTC) #2
fgorski
lgtm. Thanks for adding comments.
6 years, 1 month ago (2014-10-29 20:44:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/683913005/20001
6 years, 1 month ago (2014-10-29 20:49:06 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-29 21:42:51 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 21:43:16 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f17b85ad7985ebf3685bfc9ac23895f29247f474
Cr-Commit-Position: refs/heads/master@{#301939}

Powered by Google App Engine
This is Rietveld 408576698