Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 683893002: Classes: Add super support in methods and accessors (Closed)

Created:
6 years, 1 month ago by arv (Not doing code reviews)
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Classes: Add super support in methods and accessors This is done by installing the [[HomeObject]] on the method and the accessor functions. BUG=v8:3330 LOG=Y R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24976

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Handle numeric names #

Total comments: 1

Patch Set 4 : Change test slightly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -54 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +4 lines, -16 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +4 lines, -16 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +4 lines, -11 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 2 1 chunk +78 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +4 lines, -11 lines 0 comments Download
M test/mjsunit/harmony/classes.js View 1 2 3 1 chunk +150 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
arv (Not doing code reviews)
PTAL
6 years, 1 month ago (2014-10-28 15:26:19 UTC) #2
Dmitry Lomov (no reviews)
https://codereview.chromium.org/683893002/diff/20001/src/runtime/runtime-classes.cc File src/runtime/runtime-classes.cc (right): https://codereview.chromium.org/683893002/diff/20001/src/runtime/runtime-classes.cc#newcode160 src/runtime/runtime-classes.cc:160: CONVERT_ARG_HANDLE_CHECKED(Name, name, 1); This will break if property name ...
6 years, 1 month ago (2014-10-28 15:37:07 UTC) #3
arv (Not doing code reviews)
Handle numeric names
6 years, 1 month ago (2014-10-28 16:07:50 UTC) #4
arv (Not doing code reviews)
PTAL
6 years, 1 month ago (2014-10-28 16:08:38 UTC) #5
Dmitry Lomov (no reviews)
lgtm, a small test suggestion (optional) https://codereview.chromium.org/683893002/diff/40001/test/mjsunit/harmony/classes.js File test/mjsunit/harmony/classes.js (right): https://codereview.chromium.org/683893002/diff/40001/test/mjsunit/harmony/classes.js#newcode471 test/mjsunit/harmony/classes.js:471: get y() { ...
6 years, 1 month ago (2014-10-29 10:24:52 UTC) #6
arv (Not doing code reviews)
Change test slightly
6 years, 1 month ago (2014-10-29 11:32:41 UTC) #7
arv (Not doing code reviews)
6 years, 1 month ago (2014-10-29 11:46:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 24976 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698